Depends. We talkin' ice cream, cake or candy or what?! My favorite cake is strawberry with strawberry icing -- LOVE it. I love chocolate cake too, only slightly less than strawberry. I don't adore vanilla cake, but it's fine.
As for ice cream, I really don't love vanilla in that dept. either. I do like strawberry and chocolate, so those would probably be my picks in every dept. I like strawberry (and usually chocolate) flavored anything. Can't go wrong with strawberry.