My favourite teachers (looking back) were the tough ones who were hated by almost all the students at the time. They pushed us because they knew we could do the work and wouldn't give up. But were always there if we asked for help.
My least favourite teachers were the ones who tried to be "friends" with students. They were not good teachers as they didn't do all lessons we needed too. Or the ones that were politically correct. Or the religion teachers who deducted grades from me for questioning religion and questioning them. OH! And also ANY teacher who went on strike is a horrible teacher in my opinion. During my last year of high school, I almost didn't get to graduate because of them. And then got scolded for not supporting them.
The two teachers I love most of all, were hard asses and old school hard asses. The summer my father passed away, I went to their funerals as well and spoke at their funerals as a former student. I am now a teacher, and I try to be as good a teacher as they were to me. It is not easy being a teacher, but, hopefully I make an impact on my students lives for the better.